<html>
<head><meta charset="utf-8"><title>benchmark failure · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html">benchmark failure</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="246435270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246435270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246435270">(Jul 19 2021 at 09:49)</a>:</h4>
<p>One of the benchmarks is not building.  <a href="https://github.com/rust-lang/rustc-perf/runs/3102225289">https://github.com/rust-lang/rustc-perf/runs/3102225289</a> There seems to be lots of fingerprint errors, but I'm not sure if those are expected when the cache is not populated. There's a lot of logs (43K lines) so it's a bit hard to tell. <span class="user-mention" data-user-id="116122">@simulacrum</span> have you seen this before?</p>



<a name="246438651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246438651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246438651">(Jul 19 2021 at 10:30)</a>:</h4>
<p>Yeah the logs aren't the best</p>



<a name="246438677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246438677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246438677">(Jul 19 2021 at 10:30)</a>:</h4>
<p>But the actual error is an ice</p>



<a name="246438684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246438684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246438684">(Jul 19 2021 at 10:30)</a>:</h4>
<p>thread 'rustc' panicked at 'no errors encountered even though <code>delay_span_bug</code> issued', compiler/rustc_errors/src/lib.rs:1050:13</p>



<a name="246438708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246438708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246438708">(Jul 19 2021 at 10:30)</a>:</h4>
<p>Easier to get from <a href="https://perf.rust-lang.org/status.html">https://perf.rust-lang.org/status.html</a></p>



<a name="246438786"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246438786" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246438786">(Jul 19 2021 at 10:31)</a>:</h4>
<p>(we currently expect everything to build in CI on rustc-perf, so if rustc has a regression that can cause CI to start failing)</p>



<a name="246438858"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246438858" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246438858">(Jul 19 2021 at 10:32)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> usually I file an issue (or raise priority on an existing one)</p>



<a name="246440528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246440528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246440528">(Jul 19 2021 at 10:55)</a>:</h4>
<p>Ok I can do that</p>



<a name="246440667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246440667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246440667">(Jul 19 2021 at 10:57)</a>:</h4>
<p>probably a regression from <a href="https://github.com/rust-lang/rust/issues/87146">#87146</a></p>



<a name="246440914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246440914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246440914">(Jul 19 2021 at 11:00)</a>:</h4>
<p>Going to do a bisect</p>



<a name="246441145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246441145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246441145">(Jul 19 2021 at 11:03)</a>:</h4>
<p>no need, its parent doesn't ice</p>



<a name="246441166"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246441166" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246441166">(Jul 19 2021 at 11:03)</a>:</h4>
<p>Yea ok, I can reproduce the issue</p>



<a name="246441231"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246441231" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246441231">(Jul 19 2021 at 11:04)</a>:</h4>
<p>Let me see if I can wittle it down a bit</p>



<a name="246441540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246441540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246441540">(Jul 19 2021 at 11:08)</a>:</h4>
<p>maybe the perf bot should post a comment on a PR when <em>handwave</em>  it fails with a new error while trying to benchmark it ?</p>



<a name="246441821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246441821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246441821">(Jul 19 2021 at 11:12)</a>:</h4>
<p>We don't detect that today but it wouldn't be too hard to manage, I think</p>



<a name="246443016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246443016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246443016">(Jul 19 2021 at 11:28)</a>:</h4>
<p>Made an issue with that idea: <a href="https://github.com/rust-lang/rustc-perf/issues/918">https://github.com/rust-lang/rustc-perf/issues/918</a></p>



<a name="246443885"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246443885" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246443885">(Jul 19 2021 at 11:39)</a>:</h4>
<p>Made an issue for the ICE: <a href="https://github.com/rust-lang/rust/issues/87274">https://github.com/rust-lang/rust/issues/87274</a></p>



<a name="246447888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/benchmark%20failure/near/246447888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/benchmark.20failure.html#246447888">(Jul 19 2021 at 12:27)</a>:</h4>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="k">pub</span><span class="w"> </span><span class="k">struct</span> <span class="nc">Value</span><span class="w"> </span><span class="p">{}</span><span class="w"></span>
<span class="k">impl</span><span class="w"> </span><span class="n">Value</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="k">pub</span><span class="w"> </span><span class="k">fn</span> <span class="nf">as_u32_vec</span><span class="p">(</span><span class="bp">self</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="nb">Result</span><span class="o">&lt;</span><span class="nb">Vec</span><span class="o">&lt;</span><span class="kt">u32</span><span class="o">&gt;</span><span class="p">,</span><span class="w"> </span><span class="nb">Box</span><span class="o">&lt;</span><span class="k">dyn</span><span class="w"> </span><span class="n">std</span>::<span class="n">error</span>::<span class="n">Error</span><span class="o">&gt;&gt;</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="fm">unimplemented!</span><span class="p">()</span><span class="w"></span>
<span class="w">    </span><span class="p">}</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
<span class="k">pub</span><span class="w"> </span><span class="k">struct</span> <span class="nc">TIFFDecoder</span><span class="w"> </span><span class="p">{}</span><span class="w"></span>
<span class="k">impl</span><span class="w"> </span><span class="n">TIFFDecoder</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="k">fn</span> <span class="nf">get_tag</span><span class="p">(</span><span class="o">&amp;</span><span class="k">mut</span><span class="w"> </span><span class="bp">self</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="nb">Result</span><span class="o">&lt;</span><span class="n">Value</span><span class="p">,</span><span class="w"> </span><span class="nb">Box</span><span class="o">&lt;</span><span class="k">dyn</span><span class="w"> </span><span class="n">std</span>::<span class="n">error</span>::<span class="n">Error</span><span class="o">&gt;&gt;</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="fm">unimplemented!</span><span class="p">()</span><span class="w"></span>
<span class="w">    </span><span class="p">}</span><span class="w"></span>
<span class="w">    </span><span class="k">pub</span><span class="w"> </span><span class="k">fn</span> <span class="nf">get_tag_u32_vec</span><span class="p">(</span><span class="o">&amp;</span><span class="k">mut</span><span class="w"> </span><span class="bp">self</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="nb">Result</span><span class="o">&lt;</span><span class="nb">Vec</span><span class="o">&lt;</span><span class="kt">u32</span><span class="o">&gt;</span><span class="p">,</span><span class="w"> </span><span class="nb">Box</span><span class="o">&lt;</span><span class="k">dyn</span><span class="w"> </span><span class="n">std</span>::<span class="n">error</span>::<span class="n">Error</span><span class="o">&gt;&gt;</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="p">(</span><span class="kr">try</span><span class="o">!</span><span class="p">(</span><span class="bp">self</span><span class="p">.</span><span class="n">get_tag</span><span class="p">())).</span><span class="n">as_u32_vec</span><span class="p">()</span><span class="w"></span>
<span class="w">    </span><span class="p">}</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>
<p>(note: <code>rustc +0ecff8c623fa29cccad6f946c657e81dacd85847 --crate-name image src/lib.rs --crate-type lib</code>)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>